Fix BuildActionTelemetryTable tool#61795
Merged
JoeRobich merged 7 commits intodotnet:mainfrom Jun 13, 2022
Merged
Conversation
Follow up to dotnet#60480. The above PR led to us logging provider name instead of code action name in the telemetry when provider is using CodeAction.Create helper to create a code action. This broke the CodeActionDescriptionMap within the BuildActionTelemetryTable tool that is used to search for code action telemetry in Kusto. This PR regenerates the CodeActionDescriptionMap. I have added a helper method to the tool which can be used when required to regenerate this description map in future.
JoeRobich
reviewed
Jun 9, 2022
Member
JoeRobich
left a comment
JoeRobich
left a comment
There was a problem hiding this comment.
Thanks for this change. Just needs a little cleanup of the generated descriptions.
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Contributor
Author
Seems like a fully automated approach to generate descriptions is not completely feasible. Hopefully, we don't need to refresh this table too often. |
JoeRobich
approved these changes
Jun 13, 2022
ryzngard
approved these changes
Jun 13, 2022
ghost
added this to the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #60480.
The above PR led to us logging provider name instead of code action name in the telemetry when provider is using CodeAction.Create helper to create a code action. This broke the CodeActionDescriptionMap within the BuildActionTelemetryTable tool that is used to search for code action telemetry in Kusto.
This PR regenerates the CodeActionDescriptionMap. I have added a helper method to the tool which can be used when required to regenerate this description map in future.